Add hello-world-channel example. #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlenDC
reviewed
Jul 29, 2025
|
No, not entirely. The button calls set-delay on-click, while the message
calls hello-world data-on-load.
…On Tue, 29 Jul 2025 at 20:59, Glen De Cauwsemaecker < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In examples/hello-world-channel.html
<#3 (comment)>
:
> @@ -0,0 +1,42 @@
+<!-- This is auto-generated by Datastar. DO NOT EDIT. -->
Is this not the same example file as the hello world html file? If so I
would just use the same file to make it easier for maintenance
—
Reply to this email directly, view it on GitHub
<#3 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAPUXDYJ3CLO22DD4VEKO33K7ACDAVCNFSM6AAAAACCUYEKJGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANRYHAYDKMJYGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
GlenDC
approved these changes
Jul 30, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.