-
Notifications
You must be signed in to change notification settings - Fork 4
Doc: documentation overhaul, cljdoc compatibility, version bumps #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Updated dependencies - Adapter libraries now depend on the core SDK. There is no longer a need to explicitly depend on the core SDK. - New articles have been added to the `doc` directory - Several docstrings have been added / updated - New babashka tasks to help running a local cljdoc instance and ingesting the docs locally - The build process now adds libraries interdependencies automatically - libraries are now in a libraries directory instead of the root of the project - Malli schemas have been split into 3 libraries
@@ -13,14 +13,14 @@ | |||
- [[content-encoding]] | |||
|
|||
With this 3 keys we can control buffering aspects of our SSE connction and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"With this" -> "With these"
@@ -25,7 +27,10 @@ | |||
|
|||
|
|||
|
|||
(defn ->sse-gen [& _] | |||
(defn ->sse-gen | |||
"Returns a SSEGenerator that whose [[starfederation.datastar.clojure.protocols/send-event!]] implementation doesn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop the "that"
Maybe rewrite as 'Returns an SSEGenerator whose [[starfederation.datastar.clojure.protocols/send-event!]] implementation is a stub that returns the event string instead of sending it.'
`:body` of the request) | ||
|
||
We do not impose any json parsing library. This means that you need to bring | ||
your own to parse the returned valuue into Clojure data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"valuue" -> "value"
doc
directory