Skip to content

Conversation

JeremS
Copy link
Collaborator

@JeremS JeremS commented Sep 12, 2025

  • Updated dependencies
  • Adapter libraries now depend on the core SDK. There is no longer a need to explicitly depend on the core SDK.
  • New articles have been added to the doc directory
  • Several docstrings have been added / updated
  • New babashka tasks to help running a local cljdoc instance and ingesting the docs locally
  • The build process now adds libraries interdependencies automatically
  • libraries are now in a libraries directory instead of the root of the project
  • Malli schemas have been split into 3 libraries

- Updated dependencies
- Adapter libraries now depend on the core SDK. There is no longer a
  need to explicitly depend on the core SDK.
- New articles have been added to the `doc` directory
- Several docstrings have been added / updated
- New babashka tasks to help running a local cljdoc instance and
  ingesting the docs locally
- The build process now adds libraries interdependencies automatically
- libraries are now in a libraries directory instead of the root of the
  project
- Malli schemas have been split into 3 libraries
@@ -13,14 +13,14 @@
- [[content-encoding]]

With this 3 keys we can control buffering aspects of our SSE connction and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"With this" -> "With these"

@@ -25,7 +27,10 @@



(defn ->sse-gen [& _]
(defn ->sse-gen
"Returns a SSEGenerator that whose [[starfederation.datastar.clojure.protocols/send-event!]] implementation doesn't

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop the "that"

Maybe rewrite as 'Returns an SSEGenerator whose [[starfederation.datastar.clojure.protocols/send-event!]] implementation is a stub that returns the event string instead of sending it.'

`:body` of the request)

We do not impose any json parsing library. This means that you need to bring
your own to parse the returned valuue into Clojure data.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"valuue" -> "value"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants