Prevent dynamic data from being output on cached pages #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the gtm_server_side_is_page_cached filter (provided by the user) to determine whether it’s safe to output dynamic or sensitive data. As an additional safeguard, we insert an HTML comment '<!-- DO NOT CACHE -->' whenever such data is output. This comment can be used to scan for potential data leaks in cached content. At a minimum, users can include a check for this comment in their monitoring systems and trigger an alert or failure if it’s detected on a page that should be cached, such as the homepage.
|
This should partially solve #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the gtm_server_side_is_page_cached filter (provided by the user) to determine whether it’s safe to output dynamic or sensitive data.
As an additional safeguard, we insert an HTML comment '' whenever such data is output. This comment can be used to scan for potential data leaks in cached content.
At a minimum, users can include a check for this comment in their monitoring systems and trigger an alert or failure if it’s detected on a page that should be cached, such as the homepage.