Skip to content

Remove unused postprocess of param name #8387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

TomeHirata
Copy link
Collaborator

Remove postprocess_parameter_name call which is no-op now

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the now-no-op postprocess_parameter_name function and its invocations to streamline parameter naming logic.

  • Removes calls to postprocess_parameter_name in add_parameter and named_sub_modules
  • Deletes the unused postprocess_parameter_name definition and commented-out legacy logic

@okhat okhat merged commit 85de4d1 into stanfordnlp:main Jun 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants