Add quote rule to the lint rules #8383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds the flake8-quotes (Q) rule to enforce a consistent use of double quotes across the codebase, and updates several files accordingly.
- Updated test assertions in tests/predict/test_code_act.py to use double quotes.
- Modified pyproject.toml to include the "Q" rule.
- Adjusted string literals in multiple source files to be consistent with the lint rule.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/predict/test_code_act.py | Changed dict key quotes from single to double quotes to comply with the new lint rule. |
| pyproject.toml | Added the "Q" rule for flake8-quotes. |
| dspy/teleprompt/grpo.py | Converted single quotes to double quotes in function parameters/assertions for consistency. |
| dspy/teleprompt/avatar_optimizer.py | Updated string multiplication to use double quotes. |
| dspy/propose/utils.py | Replaced single quotes with double quotes for regex patterns and string joins. |
| dspy/propose/grounded_proposer.py | Changed single quotes to double quotes in string literals. |
| dspy/propose/dataset_summary_generator.py | Updated key delimiter quotes for consistency. |
| dspy/primitives/python_interpreter.py | Converted string literals to double quotes in command configuration. |
| dspy/adapters/utils.py | Adjusted string join delimiter to double quotes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flake8-quotes (Q) so that we don't manually fix quote preference.