-
Notifications
You must be signed in to change notification settings - Fork 38
Feature/dns skip wait and partial state #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PatrickKoss
wants to merge
28
commits into
stackitcloud:main
Choose a base branch
from
PatrickKoss:feature/dns-skip-wait
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,694
−35
Open
Changes from 18 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
8712b73
add continue attribute for observability service alert config
PatrickKoss 7ef4213
adjust the acceptance test observability
PatrickKoss 702122b
adjust docs
PatrickKoss 56eb265
add continue in another case
PatrickKoss b405ce7
Merge branch 'main' into main
PatrickKoss 188f0b7
Merge branch 'stackitcloud:main' into main
PatrickKoss 13fdd53
remove continue attribute from root
PatrickKoss 113bbb9
fix acc test
PatrickKoss e073ec2
Merge branch 'stackitcloud:main' into main
PatrickKoss 8118f17
fix docs
PatrickKoss 3e1a403
fix unit tests
PatrickKoss 039719f
remove route types
PatrickKoss 6ffe516
Merge branch 'main' into main
rubenhoenle e74f9f8
Merge branch 'stackitcloud:main' into main
PatrickKoss 4e99f0d
Merge branch 'stackitcloud:main' into main
PatrickKoss 55183c5
Merge branch 'stackitcloud:main' into main
PatrickKoss ee3a0c8
add skip wait and set partial model
PatrickKoss 76fc503
fix linting errors
PatrickKoss de09817
revert formatting
PatrickKoss e7649c2
revert formatting
PatrickKoss 037cece
import state
PatrickKoss 265836f
downlint lint from releases + remove read id check
PatrickKoss ba8ecc8
Merge branch 'main' into feature/dns-skip-wait
PatrickKoss 1196efb
fix pipeline linting
PatrickKoss 50f1f37
adjust SetModelFieldsToNull to handle complex objects and lists
PatrickKoss 873f875
fix linting
PatrickKoss 6e89bf9
fix linting
PatrickKoss b769ba1
add dns wait warn log for tf idempotency
PatrickKoss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,19 @@ | ||
| #!/usr/bin/env bash | ||
| # This script lints the SDK modules and the internal examples | ||
| # Pre-requisites: golangci-lint | ||
| # Pre-requisites: golangci-lint (provided by Makefile or system) | ||
| set -eo pipefail | ||
|
|
||
| ROOT_DIR=$(git rev-parse --show-toplevel) | ||
| GOLANG_CI_YAML_PATH="${ROOT_DIR}/golang-ci.yaml" | ||
| GOLANG_CI_ARGS="--allow-parallel-runners --timeout=5m --config=${GOLANG_CI_YAML_PATH}" | ||
|
|
||
| if type -p golangci-lint >/dev/null; then | ||
| : | ||
| else | ||
| echo "golangci-lint not installed, unable to proceed." | ||
| # Use provided golangci-lint binary or fallback to system installation | ||
| GOLANGCI_LINT_BIN="${1:-golangci-lint}" | ||
|
|
||
| if [ ! -x "${GOLANGCI_LINT_BIN}" ] && ! type -p "${GOLANGCI_LINT_BIN}" >/dev/null; then | ||
| echo "golangci-lint not found at ${GOLANGCI_LINT_BIN} and not installed in PATH, unable to proceed." | ||
| exit 1 | ||
| fi | ||
|
|
||
| cd ${ROOT_DIR} | ||
| golangci-lint run ${GOLANG_CI_ARGS} | ||
| ${GOLANGCI_LINT_BIN} run ${GOLANG_CI_ARGS} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running bash scripts blindly from a master branch of another repository is a no-go for me, sorry
Overall, what's the point of this? This whole thing feels wrong to me. For managing development dependencies there are things like dev containers, devenvs, nix flakes, ...
I'm aware we're not providing any of these currently, but this download process inside the Makefile seems pretty hacky to me 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that was a bit too ambitious. You know once you copy it from somewhere you always copy it :P
I replaced it with downloading from the releases which should be secure.
It is actually quite typically to download binaries that are needed to interact with the application (like linting, kubectl, kind, helm, etc) via scripts/make. In many stackit projects that is already the case. And there are also many opensource projects that do similar things like:
I guess many ways solve the same problem. Currently my biggest problem is that I cannot lint locally since there are version diffs between my installed golangci lint and the one in the pipeline. Therefore I want to have a make command that runs the same version in the pipeline as in our local env. Some might say that is the shift left approach.