-
-
Notifications
You must be signed in to change notification settings - Fork 23
Change axis default on a number of functions in uproot-raw codegen #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't like this. I get why you are doing this. But this is magic and now behaves differently than regular code. So what users learn will break here.
btw - if axis argument is specified twice will this work?
It will work if the user specifies I understand why this would make one uncomfortable but the fact is that essentially every new user I've seen work with the The equivalent |
I suppose we could make it an option in the |
Ok - that makes sense to me. In the documentation could we also make it very clear? I guess the fundamental problem is that |
@ponyisi please update the docs as part of this PR |
@BenGalewsky the docs will go into the servicex_frontend anyway, no? |
Ah, right |
bb6e241
to
6de30b4
Compare
@BenGalewsky Documentation in ssl-hep/ServiceX_frontend#606 . I also added a query option to allow the user to revert this change, as discussed in the Thursday meeting. Both modes have been tested on testing-3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
It would be also nice to specify the ServiceX backend version with this change in the client documentation ssl-hep/ServiceX_frontend#606 |
We make many
awkward
functions available when writing cuts and expressions for uproot. A lot of these default to operating on the entire array at once (axis=0
) in ways that make no sense for an event-by-event cut mask. In general this default causes a lot of errors. We will override those defaults here (we believe the defaults are so incorrect that nobody with correct code will be affected by this). The axis can still be overridden if people want. The list of functions with changed defaults will be given in the frontend documentation.