More general python codegen #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponyisi
requested review from
BenGalewsky,
kyungeonchoi,
gordonwatts and
MattShirley
|
I don't understand how this works? How does the sidecar know to pick up the user specified file? |
|
@BenGalewsky The sidecar tells the codegen shim what file name to produce. This PR introduces a route where user code can just directly produce this file, instead of returning an awkward array which the codegen shim then writes to that file. |
gordonwatts
reviewed
May 12, 2025
code_generator_python/python_code_generator/templates/transform_single_file.py
Outdated
Show resolved
Hide resolved
MattShirley
approved these changes
May 20, 2025
BenGalewsky
reviewed
May 21, 2025
code_generator_python/python_code_generator/templates/transform_single_file.py
Outdated
Show resolved
Hide resolved
ponyisi
force-pushed
the
more-general-python-codegen
branch
from
53bd138 to
87dfa6f
Compare
BenGalewsky
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the function signature
in addition to
so Python transformers can create arbitrary ROOT file output.