Update document regarding Stream usage #17219
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tran Ngoc Nhan <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Jun 17, 2025
There was a problem hiding this comment.
Thanks, @ngocnhan-tran1996! Will you please make the language change listed and also move it to https://github.com/spring-projects/spring-security/blob/main/CONTRIBUTING.adoc#code-style
| @@ -21,6 +21,8 @@ We welcome your involvement in the Spring Security project. | |||
| There are many ways to contribute, including answering questions on Stack Overflow, writing new code, improving existing code, assisting with documentation, developing samples or tutorials, reporting bugs, or simply making suggestions. | |||
| For more information, see our https://github.com/spring-projects/spring-security/blob/main/CONTRIBUTING.adoc[Contributing] documentation. | |||
|
|
|||
| NOTE: Avoid usage of the Stream API for performance reasons. See https://github.com/spring-projects/spring-security/issues/7154[Spring Issue #7154] for more details. | |||
There was a problem hiding this comment.
This was the old guidance. Let's update the guidance to:
Since the Stream API is https://github.com/spring-projects/spring-security/issues/7154[much slower] than for loops, please use them judiciously.
The team may ask you to change to a for loop if the given code is along a hot path.
jzheaux
added
in: docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-17097