Add default redirect URI for OAuth2 client registration #16871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When redirect URI is not provided for an OAuth2 client registration with
authorization code grant type, default it to {baseUrl}/login/oauth2/code/{registrationId}.
Closes spring-projectsgh-16377
Signed-off-by: yybmion <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, OAuth2 client registration requires a redirect URI, and omitting it throws an exception during application startup. However, in most cases, users would use the standard pattern
{baseUrl}/login/oauth2/code/{registrationId}.Closes gh-16377
Implementation
ClientRegistration.Builder.build()method to set a default redirectUri value whenTesting