class level support for @JsonView in JsonViewResponseBodyAdvice #35350
+190
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
This commit also includes related refinements of JdbcTemplate#getSingleColumnRowMapper and ObjectUtils#addObjectToArray. Closes spring-projectsgh-35340
bclozel
added
status: invalid
|
Hey @asifebrahim, I am not sure to understand why you closed this PR which seems to fix #35343 before we had a chance to review it. Could you explain? |
|
i thought someone else was assigned to it so that's why..I'll reopen |
quaff
reviewed
Aug 21, 2025
| return super.supports(returnType, converterType) && returnType.hasMethodAnnotation(JsonView.class); | ||
| return super.supports(returnType, converterType) && | ||
| (returnType.hasMethodAnnotation(JsonView.class) || | ||
| returnType.getDeclaringClass().isAnnotationPresent(JsonView.class)); |
There was a problem hiding this comment.
Should @JsonView on super type be considered?
sdeleuze
added
in: web
|
After more thoughts and discussion with the team, we prefer to decline this feature originally proposed in #35343 because the |
sdeleuze
added
the
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the necessary changes with a test file
Closes 35343
Signed-off-by: Asif Ebrahim [email protected]