Skip to content

Conversation

JohnyRicio
Copy link

@JohnyRicio JohnyRicio commented Jun 16, 2025

Fixes #284

@kohlerdominik
Copy link
Contributor

Great work. I think, you have to increase the minimal version of symfony/validator here, to make the automated tests succeed, though. Currently, the prefer-lowest test will check symfony/validator:v4.4.9

Check, when support for named arguments was introduced to find the new lowest supported version.

@JohnyRicio
Copy link
Author

Composer was modified. Now test passing with warnings, but not from my MR. You can check it. Also there is some phpstan issue not from my MR. You can check it.

@sprain
Copy link
Owner

sprain commented Jun 17, 2025

Thanks for your work, @JohnyRicio & @kohlerdominik!

Could you merge in the current state of develop branch? I updated the CI setup there so that tests can run again here on Github.

I am a hesistant about dropping support for Symfony 5 dependencies, as it's still getting security updates. We would not have the need to make this drop until we want to support symfony/validator in version 8. Therefore I might postpone merging this.

@JohnyRicio
Copy link
Author

The branch has been updated.

Regarding support: you can maintain multiple versions if you wish — for example, with support for Symfony 5 using validator <= 7.2, and the latest in the master branch. This approach is used in many other projects as well. But as you know, you're the owner and main maintainer, so the decision is entirely up to you.

@sprain
Copy link
Owner

sprain commented Jun 17, 2025

Thanks for updating!

you can maintain multiple versions if you wish

I could, but the fact remains that a deprecation warning is not a bug. It's just a notice that in the future a change will be required. Therefore it's not worth adding complexity to this library because of it.

I will happily merge this PR once the time has come for it.

@sprain sprain changed the title Change call of symfony validator Drop support for symfony/validator <v6 Jun 17, 2025
@JohnyRicio
Copy link
Author

We have path for it. When you will merge it, than we will know it and we will remove the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP Deprecated: Since symfony/validator 7.3

3 participants