-
-
Notifications
You must be signed in to change notification settings - Fork 87
Drop support for symfony/validator <v6 #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Great work. I think, you have to increase the minimal version of symfony/validator here, to make the automated tests succeed, though. Currently, the Check, when support for named arguments was introduced to find the new lowest supported version. |
Composer was modified. Now test passing with warnings, but not from my MR. You can check it. Also there is some phpstan issue not from my MR. You can check it. |
Thanks for your work, @JohnyRicio & @kohlerdominik! Could you merge in the current state of develop branch? I updated the CI setup there so that tests can run again here on Github. I am a hesistant about dropping support for Symfony 5 dependencies, as it's still getting security updates. We would not have the need to make this drop until we want to support |
The branch has been updated. Regarding support: you can maintain multiple versions if you wish — for example, with support for Symfony 5 using validator <= 7.2, and the latest in the master branch. This approach is used in many other projects as well. But as you know, you're the owner and main maintainer, so the decision is entirely up to you. |
Thanks for updating!
I could, but the fact remains that a deprecation warning is not a bug. It's just a notice that in the future a change will be required. Therefore it's not worth adding complexity to this library because of it. I will happily merge this PR once the time has come for it. |
We have path for it. When you will merge it, than we will know it and we will remove the path. |
Fixes #284