Add `tape.toml` for configs #26

4rjunc · 2025-08-07T08:08:11Z

PR for #16

I have pushed code of simple implementation of using tape.toml . In the following code change of only rpc_url is used from tape.toml config file. Couple of changes I made

add toml crate for handling toml file
removed default cluster option of l from cli args
priority is given to cli commands. if cluster is mention in cli command, rpc_url from tape.toml wont be used. if not it will be used.
if config is loaded from tape.toml it is passed through cli context
tape.toml is created at home dir

I tested the above change in archive command

~/tape.toml

[solana]
rpc_url = "https://api.devnet.solana.com"
ws_url = "wss://api.devnet.solana.com/"
commitment = "confirmed"

cargo run -p tapedrive-cli --manifest-path ~/Documents/solana/tape/cli/Cargo.toml archive
cargo run -p tapedrive-cli --manifest-path ~/Documents/solana/tape/cli/Cargo.toml archive -ul

Nagaprasadvr · 2025-08-07T10:56:56Z

Cool ,
can u disable rust formatting, this repo is not using rust formatting and the pr will add unnecessary changes

Nagaprasadvr · 2025-08-07T10:58:09Z

Also i feel we dont wanna use cli args because the reason for adding toml is to make things easier to configure wdyt @zfedoran

4rjunc · 2025-08-07T12:20:20Z

add rustfmt.toml to disable auto formatting. dropped the commits with auto formatted code. redone the changes to last two commits.

zfedoran · 2025-08-07T18:09:32Z

Welcome @4rjunc, I hope this is one of many PRs, I'd love to see more in the future.

I'm curious, why are we removing the local cluster option?

4rjunc · 2025-08-07T20:25:05Z

I'm curious, why are we removing the local cluster option

I removed the default local cluster option because tape.toml is generated on first run with a default rpc_url (devnet). The CLI checks for an rpc_url in the options first if defaults exist, it won't use the config value.

zfedoran · 2025-08-07T23:38:53Z

Ah understood, I thought the l option was being removed entirely, not just the default.

4rjunc · 2025-08-09T03:08:40Z

Also i feel we dont wanna use cli args because the reason for adding toml is to make things easier to configure wdyt @zfedoran

Quoting this again in case you missed replying @zfedoran

Nagaprasadvr

few things to update , can u also add a unit test to test the toml parsing works properly

cli/src/cli.rs

cli/src/config.rs

Nagaprasadvr · 2025-08-22T03:16:30Z

cli/src/config.rs

+    }
+
+    /// validate values in tape.toml
+    fn validate(&self) -> anyhow::Result<()> {


we also need to check urls are right here, just check for valid url using grep or something

cli/src/config.rs

zfedoran · 2025-08-22T18:53:00Z

So there is a non-zero chance that we may point tapedrive at all three clusters at the same time, but only one would be considered primary (where tokens are earned). Does this remove the need for the config file?

I guess not, but it might be worth thinking about what this file would look like with more than one source.

@Nagaprasadvr what are your thoughts?

Nagaprasadvr · 2025-08-23T01:10:16Z

So there is a non-zero chance that we may point tapedrive at all three clusters at the same time, but only one would be considered primary (where tokens are earned). Does this remove the need for the config file?

I guess not, but it might be worth thinking about what this file would look like with more than one source.

@Nagaprasadvr what are your thoughts?

For that we can just change the cluster url when we spawn the node in the config file , ig along with this we can have a field primary_cluster to mark which cluster is primary to use

Nagaprasadvr · 2025-08-23T09:19:39Z

So there is a non-zero chance that we may point tapedrive at all three clusters at the same time, but only one would be considered primary (where tokens are earned). Does this remove the need for the config file?

I guess not, but it might be worth thinking about what this file would look like with more than one source.

@Nagaprasadvr what are your thoughts?

U mean simultaneously running tape node on multiple clusters ?

@zfedoran

zfedoran · 2025-08-24T02:10:33Z

So there is a non-zero chance that we may point tapedrive at all three clusters at the same time, but only one would be considered primary (where tokens are earned). Does this remove the need for the config file?
I guess not, but it might be worth thinking about what this file would look like with more than one source.
@Nagaprasadvr what are your thoughts?

U mean simultaneously running tape node on multiple clusters ?

@zfedoran

Yeah, exactly this. The premise is that users can write wherever it is cheapest. Assuming they are okay with lower recovery guarantees.

Nagaprasadvr · 2025-08-24T11:38:42Z

So there is a non-zero chance that we may point tapedrive at all three clusters at the same time, but only one would be considered primary (where tokens are earned). Does this remove the need for the config file?
I guess not, but it might be worth thinking about what this file would look like with more than one source.
@Nagaprasadvr what are your thoughts?

U mean simultaneously running tape node on multiple clusters ?
@zfedoran

Yeah, exactly this. The premise is that users can write wherever it is cheapest. Assuming they are okay with lower recovery guarantees.

What is the difference will be in this case between a primary cluster ,(possibly mainnet ) and other clusters like devnet and testnet

4rjunc · 2025-08-26T04:43:20Z

@Nagaprasadvr I have pushed code addressing your comments. lmk if this needs to be changed. If this looks good to go, I will start working on code to pass values from tape.toml.

Nagaprasadvr

looking good

cli/src/config.rs

cli/src/main.rs

tape.example.toml

cli/src/config.rs

zfedoran · 2025-08-27T00:31:21Z

Lots of good stuff in here.

@4rjunc if you'd like, I'd love to give you access to the dev channel in discord

4rjunc · 2025-08-27T04:31:00Z

thank you!

@zfedoran i haven't joined the discord yet. i will join now. my username: 4rjunc

Nagaprasadvr

Few things to fix

cli/src/cli.rs

cli/src/config.rs

Nagaprasadvr · 2025-09-02T00:51:35Z

cli/src/main.rs


-    let context = Context::try_build(&cli)?;
+    let config = match TapeConfig::load_with_path(&cli.config_path) {


Let's just do this

let config = TapeConfig::load(&cli.config)?;

Move this inside context so we can get everything from context

cli/src/config.rs

zfedoran · 2025-09-02T16:46:35Z

This is looking really awesome @4rjunc. One more thing I'd love to see in here is the miner name. The current approach uses the word "default", which is fine, but we might as well put it in the config.

@Nagaprasadvr what are your thoughts?

(related issue: #36)

Nagaprasadvr · 2025-09-02T17:05:05Z

This is looking really awesome @4rjunc. One more thing I'd love to see in here is the miner name. The current approach uses the word "default", which is fine, but we might as well put it in the config.

@Nagaprasadvr what are your thoughts?

(related issue: #36)

Yeah definitely ig i missed it but it's a good addition

4rjunc · 2025-09-02T18:25:21Z

This is looking really awesome @4rjunc. One more thing I'd love to see in here is the miner name. The current approach uses the word "default", which is fine, but we might as well put it in the config.

@Nagaprasadvr what are your thoughts?

(related issue: #36)

thank you!

you mean to use a custom name instead of "default" in this line right ?

Nagaprasadvr · 2025-09-03T00:40:09Z

This is looking really awesome @4rjunc. One more thing I'd love to see in here is the miner name. The current approach uses the word "default", which is fine, but we might as well put it in the config.
@Nagaprasadvr what are your thoughts?
(related issue: #36)

thank you!

you mean to use a custom name instead of "default" in this line right ?

Let's add miner_name to miner config and hardcode it to "default"

Nagaprasadvr · 2025-09-03T00:42:17Z

Hey @4rjunc ig we have changes from previous commits did u rebase this ?

zfedoran · 2025-09-03T00:45:05Z

This is looking really awesome @4rjunc. One more thing I'd love to see in here is the miner name. The current approach uses the word "default", which is fine, but we might as well put it in the config.
@Nagaprasadvr what are your thoughts?
(related issue: #36)

thank you!

you mean to use a custom name instead of "default" in this line right ?

Yes, exactly this

> transaction > performance > identity > solana > storage > network > logging feat: add validate + default values for toml.config feat: log_level is enum fix: resolving comments > change the `max_memory_mb` 2gb -> 16 gb > add few comments on what to change fix: remove the `NetworkConfig` feat: add enum for commitment level > add a impl for `CommitmentLevel` fix: fix the keypair loading up from ~ path feat: removed the helper function for tilde, add function used in anchor feat: add abstract StorageConfig feat: add URL validation fix: rename performance -> mining_config > add max_poa_thread > add max_pow_thread feat: better error handling for config::load() - ConfigFileNotFound - InvalidUrl(String) - KeypairNotFound(String) - HomeDirectoryNotFound - FileReadError(std::io::Error) - ParseError(toml::de::Error) - DefaultConfigCreationFailed(String) feat: add `--config` option feat: add error handling for config load > create new config is not found in default path, `--config` is not used > if config file not found in given path -> error will be shown feat: add `--config` option feat: add error handling for config load > create new config is not found in default path, `--config` is not used > if config file not found in given path -> error will be shown

cli/src/config.rs

cli/src/cli.rs

Nagaprasadvr

Few nits

tape.example.toml

cli/src/cli.rs

cli/src/config.rs

> rm keypair_path > update keypair_path() helper function

A

4rjunc force-pushed the toml branch from 16add07 to 89b00cf Compare August 7, 2025 12:17

Nagaprasadvr suggested changes Aug 22, 2025

View reviewed changes

Nagaprasadvr suggested changes Aug 26, 2025

View reviewed changes

4rjunc force-pushed the toml branch 2 times, most recently from 6b1229a to 496b5dc Compare September 1, 2025 18:20

Nagaprasadvr suggested changes Sep 2, 2025

View reviewed changes

4rjunc added 3 commits September 3, 2025 14:31

Squash

f111683

fix: removed duplicate lines

ba74f59

4rjunc added 2 commits September 3, 2025 14:31

fix: better names to structs and vars

e661c8e

feat: move config load-up -> Context:try_build

c561878

4rjunc force-pushed the toml branch from 49fc7be to c561878 Compare September 3, 2025 09:03

Nagaprasadvr suggested changes Sep 4, 2025

View reviewed changes

cli/src/config.rs Show resolved Hide resolved

cli/src/cli.rs Outdated Show resolved Hide resolved

fix: add miner_name

596886a

Nagaprasadvr suggested changes Sep 10, 2025

View reviewed changes

tape.example.toml Outdated Show resolved Hide resolved

cli/src/cli.rs Outdated Show resolved Hide resolved

cli/src/config.rs Outdated Show resolved Hide resolved

cli/src/config.rs Outdated Show resolved Hide resolved

4rjunc added 4 commits September 11, 2025 11:13

feat: reduce match block of config loadup

d5177bb

imp: change the args in get_keypair_path fn

374e13e

imp: move the keypair_path -> Solana, remove Identity

bf32c1f

imp: logs default config creation path

50bfabf

4rjunc force-pushed the toml branch from 6db09f8 to 50bfabf Compare September 11, 2025 05:58

4rjunc added 2 commits September 11, 2025 21:00

feat: add config field to Context

4fa2a94

> rm keypair_path > update keypair_path() helper function

feat: add config for mine

02d7048

A


		let context = Context::try_build(&cli)?;
		let config = match TapeConfig::load_with_path(&cli.config_path) {

Add tape.toml for configs #26

Are you sure you want to change the base?

Add tape.toml for configs #26

Uh oh!

Conversation

4rjunc commented Aug 7, 2025

Uh oh!

Nagaprasadvr commented Aug 7, 2025

Uh oh!

Nagaprasadvr commented Aug 7, 2025

Uh oh!

4rjunc commented Aug 7, 2025

Uh oh!

zfedoran commented Aug 7, 2025

Uh oh!

4rjunc commented Aug 7, 2025

Uh oh!

zfedoran commented Aug 7, 2025

Uh oh!

4rjunc commented Aug 9, 2025

Uh oh!

Nagaprasadvr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nagaprasadvr Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zfedoran commented Aug 22, 2025

Uh oh!

Nagaprasadvr commented Aug 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nagaprasadvr commented Aug 23, 2025

Uh oh!

zfedoran commented Aug 24, 2025

Uh oh!

Nagaprasadvr commented Aug 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

4rjunc commented Aug 26, 2025

Uh oh!

Nagaprasadvr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zfedoran commented Aug 27, 2025

Uh oh!

4rjunc commented Aug 27, 2025

Uh oh!

Nagaprasadvr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nagaprasadvr Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zfedoran commented Sep 2, 2025

Uh oh!

Nagaprasadvr commented Sep 2, 2025

Add `tape.toml` for configs #26

Add `tape.toml` for configs #26

Nagaprasadvr Aug 22, 2025 •

edited

Loading

Nagaprasadvr commented Aug 23, 2025 •

edited

Loading

Nagaprasadvr commented Aug 24, 2025 •

edited

Loading

Nagaprasadvr Sep 2, 2025 •

edited

Loading

4rjunc commented Sep 2, 2025 •

edited

Loading

Nagaprasadvr commented Sep 3, 2025 •

edited

Loading