feat: add core lib handling #448
Conversation
wtobis-splunk
requested review from
hsekowski-splunk and
rkumarkhaniya-crest
| This way, even if the TA path added to sys.path contains the specified library, | ||
| Python will always reference the already cached library from the Splunk Python path. | ||
| """ | ||
| lib_module = importlib.import_module(lib_name) |
There was a problem hiding this comment.
I'm wondering if this way of importing wouldn't cause issue in the future if, for any reason, we'd like to override some library that comes with Splunk
I'd be more comfortable with something that just checks if there is a possibility to import rather than importing (eg. importlib.util.find_spec)
There was a problem hiding this comment.
Right now we're doing something opposite - we're overriding our libraries with the ones from Splunk. In this case if some lib does not exists, it is an error and should be found during testing
| pass | ||
|
|
||
|
|
||
| def handle_splunk_provided_lib(lib_name: str): |
There was a problem hiding this comment.
I do believe that should be more meaningful what it does underneath - warning ... maybe even alerting - like: delete_addon_lib
There was a problem hiding this comment.
delete is not the correct word here, as deleting is just a part of the job to be done. We should find a word for both importing new one and removing leftovers
The main goal for this change is to handle libs in unified way