Fix sphinx.writers.text.TextWrapper
#13762
Merged
+236
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
commented
Jul 26, 2025
Member
Author
|
Did something change in docutils? |
Contributor
|
I relaunched the failed Docutils HEAD test and it now passes with current Docutils revision. LaTeX failure was only a duplicate because it uses Docutils HEAD since some time. See #13845 (comment) and #13845 (comment) for context. |
picnixz
commented
Sep 7, 2025
Closed
# Conflicts: # CHANGES.rst
# Conflicts: # CHANGES.rst
AA-Turner
approved these changes
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this is a temporary fix because we're still unable to correctly process combining characters (as the tests show). But fixing those cases is much more complex and I think we should rather do something in
TextWrapperitself to determine what counts as a "breakable" character. So for now, I'll keep this fix.Closes #13741