Change run async wrapper to use explicit arguments #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed after the microphone transcription example bugging out that we do some janky packing and unpacking of positional arguments in our client run and async run wrappers.
I implemented it initially for multichan dz but this can introduce an issue where channel_pairs and audiosettings get mixed up with each other.
This MR changes that so that calls to run_asynchronously and by extension, any run functions down the line now need explicit arguments (except for transcription config as this is always required).
This change should make it more obvious how to pass arguments at the cost of a few extra words typed.