-
Notifications
You must be signed in to change notification settings - Fork 20
Add speaker id to rt #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add speaker id to rt #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a couple admin notes:
- If we're bumping to major version
8.0.0
for thereal-time-client
, I would suggest we also bump a major version for the React wrapper, as it re-exports many of the same fields - We should add to this PR description notes about some of the other messages/schema changes released as part of this change. I'm happy to do this part
.map((r) => r.alternatives?.[0].content) | ||
.join(' '); | ||
process.stdout.write(`\r${finalText} \x1b[3m${partialText}\x1b[0m`); | ||
console.log(`\r${finalText} \x1b[3m${partialText}\x1b[0m`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI the reason for process.stdout.write
here was to avoid implicit line breaks, but not sure if this is dealt with another way now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no, sorry - I only changed this due to debugging, so can undo those changes!
Co-authored-by: Matt Nemitz <[email protected]>
Co-authored-by: Matt Nemitz <[email protected]>
This realtime PR: