Make the JSON indent width configurable #1852
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the discussion #1841
Changes
Today, the indent size for rendering a
JsonTextinstance is hard coded to be 3 spaces. For a deep JSON object, it'd nice if I can set the indent size to be 2 to have more rendered within the same console space. So, I propose to make the indent size configurable for anJsonTextinstance.The changes are simple:
JsonBuilderContextint IndentWidthint indentWidth, and assign its value to the read-only propertyIndentWidthInsertIndentationmethod to haveIndentation * IndentWidthinstead.IndentWidthtoJsonTextto allow user set valueJsonBuilderContextinstance in theBuild()method.I think it may be reasonable to make sure the value assigned to
IndentWidthis between 2 and 4 inclusively, to make user only choose from 2, 3, or 4 spaces.Please upvote 👍 this pull request if you are interested in it.