-
Notifications
You must be signed in to change notification settings - Fork 12
Support for IFC/Bonsai properties #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bimgeek
wants to merge
13
commits into
v3-dev
Choose a base branch
from
bilal/cnx-2145-add-support-for-bonsaiifc-properties
base: v3-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support for IFC/Bonsai properties #295
bimgeek
wants to merge
13
commits into
v3-dev
from
bilal/cnx-2145-add-support-for-bonsaiifc-properties
+406
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR-Morgan
requested changes
Jul 22, 2025
| @@ -0,0 +1,292 @@ | |||
| """ | |||
| All IFC-related imports are wrapped in try-except blocks to ensure the code only runs when Bonsai/ifcopenshell is available. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a better way we can do this.
The error handling here is too complex for me to be ok with it.
I think we could do something better having try catches around a re-export of ifc_properties, rather than have every single function in this file try catch exhastivly.
…support-for-bonsaiifc-properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE BEFORE #294
This PR adds support for publishing IFC properties from Blender objects imported by Bonsai BIM addon.