Skip to content

Conversation

@bimgeek
Copy link
Contributor

@bimgeek bimgeek commented Jul 18, 2025

DO NOT MERGE BEFORE #294

This PR adds support for publishing IFC properties from Blender objects imported by Bonsai BIM addon.

  • All IFC related imports are wrapped in try-except blocks to make sure code only runs when Bonsai BIM is available. When it's not installed, converter extracts only custom properties.
  • Uses the same property structure as our new IFC importer (cc @JR-Morgan ) -> Attributes, Property Sets, Element Type Property Sets, Element Type Attributes
Screenshot 2025-07-18 at 10 55 35 Screenshot 2025-07-18 at 10 55 51

@linear
Copy link

linear bot commented Jul 18, 2025

@bimgeek bimgeek requested a review from JR-Morgan July 18, 2025 07:29
@bimgeek bimgeek marked this pull request as ready for review July 18, 2025 07:36
@@ -0,0 +1,292 @@
"""
All IFC-related imports are wrapped in try-except blocks to ensure the code only runs when Bonsai/ifcopenshell is available.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a better way we can do this.
The error handling here is too complex for me to be ok with it.

I think we could do something better having try catches around a re-export of ifc_properties, rather than have every single function in this file try catch exhastivly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants