Skip to content

Edit filteredChanges in hooks.ts #7101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Edit filteredChanges in hooks.ts #7101

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8106f22
edit filteredChanges in hooks.ts
acwhite211 Jul 16, 2025
45e6d74
Update hooks.ts
acwhite211 Jul 16, 2025
30d497b
Lint code with ESLint and Prettier
acwhite211 Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions specifyweb/frontend/js_src/lib/components/WorkBench/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,18 @@ export function useHotHooks({
const filteredChanges = unfilteredChanges
.filter((change): change is CellChange => change !== null)
.filter(
([, property]) =>
(property as number) < workbench.dataset.columns.length
);
([, property]) => {
let columnIndex: number | undefined;

if (typeof property === 'number') {
columnIndex = property;
} else if (typeof property === 'string' && workbench.dataset.columns) {
columnIndex = workbench.dataset.columns.findIndex(colDef => (colDef as unknown as { readonly data: string }).data === property);
}

return columnIndex !== undefined && columnIndex >= 0 && columnIndex < workbench.dataset.columns.length;
}
);
if (
filteredChanges.length === unfilteredChanges.length ||
workbench.hot === undefined
Expand Down