Skip to content

Fix WB Rollback #6402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: production
Choose a base branch
from
Draft

Fix WB Rollback #6402

wants to merge 1 commit into from

Conversation

acwhite211
Copy link
Member

Fixes #6401

There seems to be an issue with rolling back workbench uploads through the unupload API.

From this commit for batch edit 25eef3f

The return value for the unupload view function changed from
return http.JsonResponse(async_result.id, safe=False)
to
return http.JsonResponse("w", safe=False)

It seems reverting it might fix this issue.

A follow-up issue is that in the an unupload task might get stuck, and no new unupload task can be made on the dataset until the existing tasks finishes. So, we might want the user to be able to reset the task state from the UI.

One other thing is to allow for the option of running the unupload task in the main Specify container, rather than as a background task. This is to match this option we created for the upload task, to help with debugging.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋Back Log
Development

Successfully merging this pull request may close these issues.

Fix WB Rollback
1 participant