Enable nested to-many in Workbench #6216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggered by 82033cd on branch refs/heads/issue-2331
19 tasks
CarolineDenis
approved these changes
Mar 4, 2025
lexiclevenger
approved these changes
Mar 5, 2025
emenslin
requested changes
Mar 5, 2025
github-project-automation
bot
moved this from 📋Back Log
to Dev Attention Needed
in General Tester Board
|
@emenslin Should be fixed now. The branch didn't have the latest production changes |
emenslin
approved these changes
Mar 10, 2025
|
KU Mammals and Herpetology needs this for tracking preservation chain |
Triggered by f0822bf on branch refs/heads/issue-2331
alesan99
approved these changes
Apr 1, 2025
acwhite211
approved these changes
Apr 1, 2025
Triggered by f27581b on branch refs/heads/issue-2331
github-project-automation
bot
moved this from Dev Attention Needed
to ✅Done
in General Tester Board
sharadsw
added a commit
that referenced
this pull request
Apr 29, 2025
* Enable trees in queries * Use query construct code from #4929 * Update unit test * Remove param_count * Display tree name in query error * Update TreeRankQuery to fix implicit ORs - see: #6196 (comment) * Allow removing last row in Batch Edit * Make a missing rank info dialog which proceeds to dataset creation * Augment tree queries with missing ranks for batch edit * Lint code with ESLint and Prettier Triggered by 65f7d21 on branch refs/heads/issue-6127 * Adjust apply_batch_edit_pack for multiple trees * Add a discipline type in tests * Un-enforce TreeRankRecord in upload plan * Add loading action to missing ranks dialog * Move table name to same line in missing fields dialog * Handle case when rank name has spaces * Add a close button to missing ranks dialog * Fix frontend missing field calculation * Fix frontend to many tree error * Lint code with ESLint and Prettier Triggered by 9407376 on branch refs/heads/issue-6127 * Restrict to manys only for tree fields * Fix multiple rank in row error * Fix navigator * Fix tests * Group missing ranks by tree * Lint code with ESLint and Prettier Triggered by 7f2149d on branch refs/heads/issue-6127 * Pass filtered treedef ids to the backend - Adds checkboxes to tree names in missing ranks dialog - Splits the main batch edit file into 4 smaller files * Lint code with ESLint and Prettier Triggered by 1c29ec9 on branch refs/heads/issue-6127 * Filter trees used when rewriting batch edit dataset * Fix tests * Use TreeRankRecord in upload plan * Remove unused string * Fix visual order - For multiple trees, columns will be grouped by tree first * Revert "Fix visual order" This reverts commit a8a2ad6. * Flag to-many in tree only queries * Lint code with ESLint and Prettier Triggered by f36521c on branch refs/heads/issue-6127 * Enable nested to-many in Workbench (#6216) * Enable nested to-many in Workbench * Update test * Add upload plan changes * Update tests * Lint code with ESLint and Prettier Triggered by 82033cd on branch refs/heads/issue-2331 * Fix tests * Lint code with ESLint and Prettier Triggered by f0822bf on branch refs/heads/issue-2331 * Lint code with ESLint and Prettier Triggered by f27581b on branch refs/heads/issue-2331 * Lint code with ESLint and Prettier Triggered by cc1f85b on branch refs/heads/issue-6127 * Check for lowercase tree table names when rewriting tree rank row plan * Handle None rank * Fix tree column order * Fix tests * Revert back to sort columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2331
Warning
This PR is based on #5417. Use either a db that was used to test #5417 or create a new db
This PR enables nested to many in the data mapper and fixes some automated tests. The underlying backend support for nested to many is in #5417.
For reference:
Nested to-manys in the workbench are mapping lines that involve multiple to-many relationships. For example:
Collection Object -> Determination (to many) -> DeterminationCitation (to-many) -> ...Checklist
self-explanatory (or properly documented)
Testing instructions
CO -> Determination -> DeterminationCitation(see above)CO -> Preparation -> PreparationPropertyCO -> Preparation -> PreparationAttribute