Add authenticator selection criteria to GeneratePasskeyRegisterOptions #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing. Could you look at that? |
Fixes spatie#51 This aligns the selection criteria with documentation to allow the passkey to be "discovered". Per https://simplewebauthn.dev/docs/advanced/passkeys#server, these must be set: // "Discoverable credentials" used to be called "resident keys". The // old name persists in the options passed to `navigator.credentials.create()`. residentKey: 'required', userVerification: 'preferred',
Should be working now :) |
|
Very weird that the order of keys is different for me when running the test locally, it should be happy now. |
|
Turns out the GitHub editor also likes to auto-add EOLs. I really hope the tests pass now, please approve workflow @freekmurze. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51
Solution by @jonasvanderhaegen
This aligns the selection criteria with documentation to allow the passkey to be "discovered".
Per https://simplewebauthn.dev/docs/advanced/passkeys#server, these must be set: