Skip to content

fix: condition check for insert generated variable #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

fix: condition check for insert generated variable #813

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdf6d65
fix: condition check for insert generate variable
aakashreddy-p Sep 17, 2025
0256c56
fix: condition check for insert generate variable
aakashreddy-p Sep 17, 2025
ac038ff
fix: updated the function permission
aakashreddy-p Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/modules/workspace/services/collection.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {
BadRequestException,
ForbiddenException,
Injectable,
NotFoundException,
UnauthorizedException,
Expand Down Expand Up @@ -56,6 +57,7 @@ import { RequestBodyDto } from "@src/modules/common/models/collection.model";
import { UserRepository } from "@src/modules/identity/repositories/user.repository";
import { CollectionGenerateVariableDto } from "@src/modules/common/models/collection.model";
import { CollectionRequestService } from "./collection-request.service";
import { WorkspaceRole } from "@src/modules/common/enum/roles.enum";

@Injectable()
export class CollectionService {
Expand Down Expand Up @@ -1379,6 +1381,11 @@ export class CollectionService {
"Please provide collectionId and Generated Variables.",
);
}
await this.workspaceService.IsWorkspaceAdminOrEditor(
workspaceId,
user._id,
);
await this.checkPermission(workspaceId, user._id);
const collectionDocument = await this.getCollection(collectionId);
if (!collectionDocument) {
throw new NotFoundException("Collection is not Found.");
Expand All @@ -1387,7 +1394,7 @@ export class CollectionService {
const validGeneratedPairs = generatedPairs.filter(
(pair) => pair.key?.trim() && pair.value?.trim(),
);
if(validGeneratedPairs.length < 1){
if (validGeneratedPairs.length < 1) {
throw new BadRequestException(
"Please provide Vaild Generated Variables.",
);
Expand Down
Loading