feat: Adds forceApprove logic (SC-978) #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failing due to build size > limit once pr #104 merges it will work |
supercontracts
changed the title
supercontracts
added
Priority: High
Status: Ready for Review
and removed
Status: Blocked
labels
lucas-manuel
reviewed
May 9, 2025
hacker-DOM
previously approved these changes
May 9, 2025
There was a problem hiding this comment.
Changes _approve function in Foreign|Mainnet Controller and CurvesLib to first approve to 0 if the regular approval fails[0]. Adds tests that presumably wouldn't pass before.
[0] Failure is defined as returning non-zero returndata AND the first word (0-extended if necessary) is 0.
lucas-manuel
requested changes
May 13, 2025
lucas-manuel
approved these changes
May 14, 2025
hacker-DOM
approved these changes
May 14, 2025
|
Coverage after merging sc-978-forceApprove into dev will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #106