Skip to content

Conversation

mazm0002
Copy link

Related to space-ros/demos#50.
This PR adds assets for the lunar world, which are pulled into the lunarsim demo.

Copy link
Contributor

@mkhansenbot mkhansenbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ivanperez-keera
Copy link
Contributor

@mkhansenbot @EzraBrooks This PR leaves files in Github LFS. I've never used that. How do we want to manage that? Do we need to set anything up on our end? Do we need to copy files over so that we don't lose them if the original requester removes the files?

@ivanperez-keera
Copy link
Contributor

@mazm0002 I need to make some changes to this PR to merge the work. Can you please also give my user permission to make changes to the simulation repo under element-robotics?

@ivanperez-keera ivanperez-keera changed the title Added world assets for lunarsim (#38). Add world assets for lunarsim (#38). Aug 26, 2025
@mazm0002
Copy link
Author

@ivanperez-keera I've given you permissions, let me know if there's any issues

@ivanperez-keera
Copy link
Contributor

Update (2025/09/04): Check if PNG images should also be stored in LFS. All files should be in LFS.

We need to update the documentation to tell people that they won't get the actual files unless they have LFS enabled.

@ivanperez-keera
Copy link
Contributor

Checked that all images are stored in LFS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants