-
Notifications
You must be signed in to change notification settings - Fork 122
Returning IPv4 address for RFC1213 MIB OID .1.3.6.1.2.1.4.21.1.7 #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
levhuan
wants to merge
3
commits into
sonic-net:master
Choose a base branch
from
levhuan:azure/master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/easycla |
Update the existing tests to verify IPv6 nexthop is not included in rfc1213 MIB response Signed-off-by: Huan V Le <[email protected]>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC1213, the value of ipRouteNextHop OID (1.3.6.1.2.1.4.21.1.7) is an IPv4 address.
In a v4-in-v6 network, the nexthop list of a 0.0.0.0/0 default route may have an IPv6 address. When that happened, we notice GET-NEXT on OID 1.3.6.1.2.1.4.21.1.7 timed-out.
- What I did
Change rfc1213 MIB update_date method to include IPv4 address nexthop
- How I did it
- How to verify it
Add an IPv6 address into the list of next-hops in STATE_DB "ROUTE_TABLE:0.0.0.0/0"
Verify:
time docker exec snmp bash -c "snmpwalk -v2c -c public -r 5 -t 1 1.3.6.1.2.1.4.21.1.7"
returned in less than 6 seconds.- Description for the changelog
Return IPv4 address nexthop for rfc1213 ipRouteNextHop