Fix remove_dataacl_table fixture to correctly delete and restore DATAACL table
#21021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current implementation fails to restore dataacl table in dualtor topologies
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix
remove_dataacl_tablefixture inacl/test_stress_acl.pyto correctly restoreDATAACLtable for dualtor topologiesFixes # (#21020, https://github.com/aristanetworks/sonic-qual.msft/issues/914)
Type of change
Back port request
Approach
What is the motivation for this PR?
As DATAACL was never restored for dualtor topologies, sometimes DATAACL table was bound to the same PortChannels that carry the BGP traffic, that lead to routes corruption and various tests failing.
How did you do it?
Modified the fixture to correctly check and delete and later accordingly restore the table
How did you verify/test it?
Ran test/test_acl_stress and verified the DATAACL was being restored in teardown
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation