DHCPv4 Relay Agent High Level Design #1938
Conversation
Signed-off-by: Ashutosh Agrawal <[email protected]>
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
Hi @lolyu could you please help to check the dual tor part? |
ashutosh-agrawal
force-pushed
the
dhcpv4
branch
from
369782f to
1dba737
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
|
Hi @yaqiangz , @saiarcot895 , @lguohan , could you please create the new repo mentioned in this HLD( https://github.com/sonic-net/sonic-dhcpv4-relay) to open code PR? |
There was a problem hiding this comment.
Maybe detailing the type of OFFER packet(unicast) is more friendly
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
@prsunny @yaqiangz @selva-nexthop @jasper-hou-micas @zhangyanzhao I've addressed all the review comments on the HLD. Also, code PRs are open and I've added the link to code PRs above. Appreciate your help in quick approval of the HLD as this feature is included in the 202505 SONiC Planing table. |
|
@prsunny @zhangyanzhao This HLD has approvals from @yaqiangz from MSFT and @selva-nexthop for nexthop.ai. Also @lolyu has approved the dual-TOR specific section of the design. Appreciate your help in merging the HLD and assigning approvers for the code PRs. Code PRs: |
Signed-off-by: Ashutosh Agrawal <[email protected]>
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
|
||
| - **DHCP Acknowledgment (ACK):** The DHCP server responds with a DHCP Ack message, setting the destination IP address to the relay agent's IP address (giaddr). Upon receiving this message, the DHCP relay agent updates the packet's fields similar to the Offer message and forwards it as a unicast message to the DHCP client, completing the DHCP transaction. | ||
|
|
||
| <div align="center"> <img src=images/DHCPv4_Relay_Basic_Flow.png width=600 /> </div> |
There was a problem hiding this comment.
offer packet from server to relay agent will also be unicast, typo?
|
|
||
| DHCPv4 relay process will run in the dhcp_relay container along with DHCPv6 processes and DhcpMon. A single instance of the process will handle DHCPv4 relay functionality of all the VLANs that are configured. This process will listen to Redis for all the necessary configuration updates and will not require restarting of the container. The design is split into 3 sub-modules and the following diagram provides an overview of how they interact with each other: | ||
|
|
||
| <div align="center"> <img src=images/DHCPv4_Relay_sequence_diagram.png width=700 /> </div> |
There was a problem hiding this comment.
This diagram needs to be updated with the latest changes(COUNTERS_DB etc.)?
7 participants
This document provides a high-level design for SONiC's new DHCPv4 relay agent, which addresses limitations of the existing ISC-DHCP implementation. The document outlines the architecture, new features and configuration of the new design, and also addresses the backward compatibility concerns related to transition from isc-dhcp.
Code PRs:
sonic-dhcp-relay
yang-model
sonic-buildimage
sonic-swss-common
Testplan HLD
sonic-mgmt test
CLIs