Skip to content

Conversation

chaimann
Copy link
Contributor

@chaimann chaimann commented Jun 6, 2025

Note

Split from #6236

Summary

DRYing up controllers that reuse sorting functionality, moving #move action and related code into Moveable concern

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (e6a57c3) to head (c057d37).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...app/controllers/concerns/solidus_admin/moveable.rb 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6282      +/-   ##
==========================================
+ Coverage   88.87%   88.94%   +0.07%     
==========================================
  Files         858      859       +1     
  Lines       18413    18404       -9     
==========================================
+ Hits        16364    16369       +5     
+ Misses       2049     2035      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chaimann added 3 commits June 9, 2025 22:04
Sortable elements might not always be inside a table, so we'll identify
them by presence of "data-controller='sortable'" on their parent.
@chaimann chaimann force-pushed the admin-extract-moveable branch from 09a283e to c057d37 Compare June 10, 2025 13:08
@chaimann chaimann marked this pull request as ready for review June 10, 2025 14:13
@chaimann chaimann requested a review from a team as a code owner June 10, 2025 14:13
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks 🙏🏻

@tvdeyen tvdeyen moved this to Review in Solidus Admin Jun 11, 2025
@tvdeyen tvdeyen merged commit e19e1a7 into solidusio:main Jun 11, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Solidus Admin Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants