Skip to content

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jun 4, 2025

Summary

Adds inverse_of and dependent options to has_many relations in solidus_legacy_promotions. I'm not adding foreign keys and all that here because technically this gem won't be supported for much longer.

Extracted from #6240

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@mamhoff mamhoff requested a review from a team as a code owner June 4, 2025 11:16
@github-actions github-actions bot added the changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem label Jun 4, 2025
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (acb9cc8) to head (b681cac).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6273   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files         860      860           
  Lines       18422    18422           
=======================================
  Hits        16388    16388           
  Misses       2034     2034           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen added this to the 4.6 milestone Jun 4, 2025
@mamhoff mamhoff force-pushed the legacy-promotions-has-many branch from 6d0f384 to a9d8d37 Compare June 6, 2025 10:38
@mamhoff mamhoff force-pushed the legacy-promotions-has-many branch from a9d8d37 to b681cac Compare June 23, 2025 09:07
@tvdeyen tvdeyen merged commit 6ea03a2 into solidusio:main Jun 25, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem
Projects
Development

Successfully merging this pull request may close these issues.

3 participants