Admin stores add edit #6228
Draft
Admin stores add edit #6228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_core
chaimann
force-pushed
the
admin-stores-add-edit
branch
4 times, most recently
from
d954048 to
0e780db
Compare
github-actions
bot
added
changelog:solidus_legacy_promotions
chaimann
force-pushed
the
admin-stores-add-edit
branch
3 times, most recently
from
88e2517 to
806d939
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6228 +/- ##
==========================================
- Coverage 88.86% 86.64% -2.22%
==========================================
Files 857 520 -337
Lines 18415 11947 -6468
==========================================
- Hits 16365 10352 -6013
+ Misses 2050 1595 -455 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chaimann
force-pushed
the
admin-stores-add-edit
branch
2 times, most recently
from
53f27b5 to
5bd82da
Compare
chaimann
force-pushed
the
admin-stores-add-edit
branch
3 times, most recently
from
7d44f5a to
40e76d7
Compare
|
going to split few changes into separate PRs |
This was referenced Jun 5, 2025
Since store form will not be in a modal, change the turbo frame name to be more general :resource_form
`flash[:notice]` is what is used commonly to display a regular success toast, and we will reserve `:success` flash for alerts.
Store deletion can be aborted if we are deleting a default store, so we'll show alert in that case.
We don't have to use turbo_frames on these pages since we are not loading content into it but always do a page visit to /new and /edit routes, and when server responds with 422 and templates with validation errors we can just place relevant "id" on the topmost element of the page so its content will be replaced with turbo stream.
chaimann
force-pushed
the
admin-stores-add-edit
branch
2 times, most recently
from
9c875ee to
e45a741
Compare
|
What's the status of this PR? It's a very large draft that I don't want to just leave sitting here. |
|
@jarednorman it was waiting for flashes PR to be merged, so now I can move it forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement interface to create/edit stores.
Other changes
:resource_modalturbo frame to:resource_formand add an overridable method#resource_form_framein resources_controller, that returns default frame name:resource_form.UI select component: add support for- split to [Admin][UI] Allow select to include blank option #6279.:include_blankoption. Component now will only accept array forchoices. Updated usage in a few places where a string has been passed instead of an array (user store credits)Updated layout to accommodate alerts display. Added FlashHelper to differentiate between toast flashes and alert flashes- split to [Admin] Flashes helper and reorganization #6280.Updated usages of- split to [Admin] Flashes helper and reorganization #6280.flash[:success]toflash[:notice]to be consistentChecklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: