Make most snotes NETWIDE #93
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not thrilled about making things netwide snotes that are propagated globally anyway. |
|
Connect needs to be netwide, because only the local server knows the connection class; the others that are propagated that previously had a snote extension I'd be open to integrating into the appropriate place. But sno_globaloper was a hack (checks for umode +o), and sno_globalkline is the hackiest of hacks (checks for specific quit messages), so those definitely need to go. |
|
(The sasl_abort1 test failures are because the connect snotes are now in the server sendq) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did look through most of these to make sure they were sane, but a second set of eyes would be good. I didn't touch most snotes for bans (K/D/X lines, RESVs) because I figured we could do those when we rework ban propagation and elimination of clusters and such.