Allow for default umodes to change at runtime #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When default umodes are changed in ircd.conf, these changes will now be applied to all local clients upon receiving a /rehash. We track which umodes a user has explicitly (un)set and avoid modifying those umodes when changing the defaults -- only umodes that a user didn't explicitly touch are subject to change on rehash.
|
Hmm. It'd be nice if setting umode -R when you're already -R would mark R as a changed umode, but clearly harder to do that with how user_mode works now. |
Now when e.g. a user does mode -R when they are already -R, we will store that mode as part of their changed modes, so that should the default umodes change in the future we will not attempt to manipulate the +R flag on that user.
|
@edk0 Wasn't significantly harder to do, so I added that feature in as well. |
|
This currently sets people -Z when the default umodes change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When default umodes are changed in ircd.conf, these changes will now be
applied to all local clients upon receiving a /rehash. We track which
umodes a user has explicitly (un)set and avoid modifying those umodes
when changing the defaults -- only umodes that a user didn't explicitly
touch are subject to change on rehash.