CI: Use reusable publish-js workflow #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorisleiva
reviewed
Aug 28, 2025
| publish-js-dry-run-%: | ||
| cd "$(call make-path-trim-level,$*)" && pnpm install && pnpm version $(call level,$*) --no-git-tag-version | ||
|
|
||
| publish-js-%: |
There was a problem hiding this comment.
The previous script was named publish-j% with the following comment:
# Make defaults % to .o if nothing is provided there, and then tries to build it
# as a C project, so we do something a bit hacky, and assume that any target
# starting with "j" is actually for "js".Some of the other existing JS scripts still follow that convention. I think we should consider choosing the same naming convention for all JS scripts.
There was a problem hiding this comment.
Yeah that's a good point, I'll make them align better:
#### Problem This is very similar to solana-program#670, but for the publish-js workflow. #### Summary of changes Use the reusable workflow.
|
Ok this should be ready for another look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is very similar to #670, but for the publish-js workflow.
Summary of changes
Use the reusable workflow.