Skip to content

deps: Bump Solana deps to v2.2 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joncinque
Copy link
Contributor

Problem

The Solana 2.2 crates and tools are available, but the repo is still using 2.1.

Summary of changes

Pretty simple, but bump up the sdk crates to v2.2.1, non-sdk crates to v2.2.0, toolchain to 1.84.1, and nightly to 2024-11-22. Also add the workspace lints.

#### Problem

The Solana 2.2 crates and tools are available, but the repo is still
using 2.1.

#### Summary of changes

Pretty simple, but bump up the sdk crates to v2.2.1, non-sdk crates to
v2.2.0, toolchain to 1.84.1, and nightly to 2024-11-22. Also add the
workspace lints.
@joncinque joncinque requested a review from febo March 7, 2025 00:25
@2501babe
Copy link
Member

2501babe commented Mar 7, 2025

oh wait are we doing this now? i just mentioned offhand in another issue that i assumed we were holding at 2.1 until launch

@joncinque
Copy link
Contributor Author

Ah ok, I can hold off if you prefer. I mainly want the stake interface bumped because it's still on older versions, which is causing things like semver checks to fail

@2501babe
Copy link
Member

2501babe commented Mar 7, 2025

im not strongly opposed, just making sure we are on the same page! its probably fine since it requires no code changes

@febo
Copy link
Contributor

febo commented Mar 21, 2025

In practice we don't need to bump the interface and client dependencies, since ^2.1 would be compatible with 2.2. Is the idea to always move the dependencies to the latest? The drawback is that when we introduce a fix to one of these crates, then users will also need to bump their dependencies to the latest to get the fix.

@joncinque
Copy link
Contributor Author

I mainly want to get everything on the v2.2.1 sdk crates so that everything can benefit from the versions with relaxed dependencies. I'm hoping that the change can even help us remove the patches from the sdk repo.

@febo
Copy link
Contributor

febo commented Mar 21, 2025

I think it only needs a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants