Skip to content

Housekeeping and adding Rapperswil Software Crafters #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Housekeeping and adding Rapperswil Software Crafters #232

wants to merge 9 commits into from

Conversation

marcokuoni
Copy link

  • We will soon start a Software Crafters group in Rapperswil, Switzerland.
  • I also did some housekeeping and added Nix. Check out the commit messages.
  • To clarify: the website currently includes JavaScript and CSS both in index.html and through Packagist for mapbox. So they are being loaded twice. I tried to fix this, but it turns out the two CSS files are slightly different, which broke the popup.
    Also, the JavaScript expects MapboxGeocoder to be available in the global scope, which no longer works if we remove the script tags from index.html.
    I’ve reverted the commit and adjusted the CSS inclusion for now.
    I recommend updating Mapbox to the latest major release and cleaning up the integration properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcokuoni