Fix seek in PyAVReaderTimed #431
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moreover, it looks like here seek is used correctly: https://github.com/soft-matter/pims/blob/main/pims/pyav_reader.py#L397 |
|
Thanks, @VladyslavUsenko. I approved the CI to run, and I notice some failures that look unrelated to the change. I will take a closer look tomorrow. |
|
Hi @danielballan, any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a seek method of the
PyAVReaderTimed.The timestamp, that is computed in the
seekmethod, corresponds to stream and not to the container. This PR updatesself._stream.container.seekto seek in the stream. In my experiments, it significantly reduces the time forget_framecalls on large video files.