Fix: typo in CustomHostname#patch #87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Let me fix CI and then I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are being made? What problem are you solving?
Fixed a typo in the
lib/cloudflare/custom_hostnames.rbfile where:successwas misspelled as:sucessin the response handling logic.What feature/bug is being fixed here?
Bug fix: The typo in line 65 was causing the success check to fail, which would prevent proper handling of successful API responses in the
patchmethod of theCustomHostnameclass. This lead to unnecessaryRequestErrorexceptions being raised even when the API call was successful.Types of Changes
Contribution