fix(code): Add missing report metadata to sarif output when using CCI or code test native #6171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
This PR adds missing property metadata to the Sarif Output of the golang native code test implementation, which is used with CCI. This change affects only users of
snyk code test --report
that are accessing theuploadResult
property in the Sarif output.Where should the reviewer start?
How should this be manually tested?
By running the following command
In the resulting sarif.json the run must contain a property called
uploadResult
withreportUrl
,snapshotId
,projectId
.What's the product update that needs to be communicated to CLI users?
This changes fixes a regression between legacy code test and a new implementation, where reportUrl and other metadata was missing in the sarif output.
Risk assessment (Low | Medium | High)?
Low