allow overriding sys.stderr before calling print_error #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Cristau <[email protected]>
Signed-off-by: Julien Cristau <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Dec 22, 2015
Grabbed from smurfix/yapps#2 Package-Manager: portage-2.2.26
Author
|
Ping. |
|
These changes look good to me. @smurfix: could you merge these changes and push a new version to PyPI? |
|
any chance to get this merge (AND published on pypi) anytime soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scanner.print_line_with_pointer captures sys.stderr at definition time, meaning if it's changed later it'll still use the old one; fix that by looking for sys.stderr at each call.
Additionally, fixed stray print statements that lead to TypeError because the file imports print_function.