-
Notifications
You must be signed in to change notification settings - Fork 2
UI: Misc command tweaks #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
src/U_PREVIEW.PAS
Outdated
AddKBItem(miControl, 'Rotate left', Char(VK_LEFT), []); | ||
AddKBItem(miControl, 'Rotate right', Char(VK_RIGHT), []); | ||
AddKBItem(miControl, 'Move forth', Char(VK_UP), []); | ||
AddKBItem(miControl, 'Move back', Char(VK_DOWN), []); | ||
AddKBItem(miControl, 'Sidestep left', Char(VK_LEFT), [ssAlt]); | ||
AddKBItem(miControl, 'Sidestep right', Char(VK_RIGHT), [ssAlt]); | ||
|
||
AddKBItem(miControl, 'Look up', Char(VK_NEXT), []); | ||
AddKBItem(miControl, 'Look down', Char(VK_PRIOR), []); | ||
AddKBItem(miControl, 'Move up', 'A', []); | ||
AddKBItem(miControl, 'Move down', 'Z', []); | ||
AddKBItem(miControl, 'Look up', Char(VK_PRIOR), []); | ||
AddKBItem(miControl, 'Look down', Char(VK_NEXT), []); | ||
AddKBItem(miControl, 'Move up', 'Q', []); | ||
AddKBItem(miControl, 'Move down', 'E', []); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is a mouse navigation option it's probably ok to just remove these navigation keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can imagine some niche use cases where someone misses this but I don't think it's important. Implemented in f6b6449
src/JED_MAIN.DFM
Outdated
@@ -701,6 +701,7 @@ object JedMain: TJedMain | |||
end | |||
object Viewtogrid1: TMenuItem | |||
Caption = '&View to grid' | |||
ShortCut = 106 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could replace F2 shortcut (Gob project command) with this view-to-grid command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Implemented in 0ed0bd7 . I also decided to remove the duplicate nested button for View to Grid in favour of the top-level one (which implicitly gets priority when handling keyboard inputs).
View mode (mouse controls) is sufficient
AddKBItem(miControl, 'Move up', 'Q', []); | ||
AddKBItem(miControl, 'Move down', 'E', []); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also remove these 2 key controls, and I guess update description text above with 'Q' & 'E'.
We can reserve the 2 key controls then for future use.
Functional changes:
Label fixes: