Add warning message for exclusion of mixin members using transform #2644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugmanue
reviewed
May 27, 2025
| return new RemoveShapes(shapes, plugins).transform(this, model); | ||
| } | ||
|
|
||
| private void validateMembersFromMixin(Model model, Collection<? extends Shape> shapesToExclude) { |
There was a problem hiding this comment.
Let's be consistent with the calling method and name the arguments the same.
Suggested change
| private void validateMembersFromMixin(Model model, Collection<? extends Shape> shapesToExclude) { | |
| private void validateMembersFromMixin(Model model, Collection<? extends Shape> shapes) { |
Comment on lines
138
to
142
| LOGGER.warning(format("Excluding copied mixin member `%s` from mixin shape `%s` explicitly " | ||
| + "in `%s` will result in undefined behavior and an inconsistent model!", | ||
| memberShape.getMemberName(), | ||
| mixinShape.getId(), | ||
| container.get().getId().getName())); |
There was a problem hiding this comment.
Suggested change
| LOGGER.warning(format("Excluding copied mixin member `%s` from mixin shape `%s` explicitly " | |
| + "in `%s` will result in undefined behavior and an inconsistent model!", | |
| memberShape.getMemberName(), | |
| mixinShape.getId(), | |
| container.get().getId().getName())); | |
| LOGGER.warning(format("Excluding member `%s` from mixin shape `%s` " | |
| + "in `%s` will result in an inconsistent model", | |
| memberShape.getMemberName(), | |
| mixinShape.getId(), | |
| container.get().getId().getName())); |
… modify related docs.
joewyz
force-pushed
the
joewyz/exclude-by-trait-fix
branch
from
34ca331 to
5f7860d
Compare
sugmanue
approved these changes
May 28, 2025
sugmanue
approved these changes
May 28, 2025
sugmanue
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.