Add top-level member pattern #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a grammar pattern at the top level for members. While members at the top level aren't valid syntax, having a pattern for them means we can have syntax highlighting in rendered hover content for members. See attached image.
milesziemer
requested review from
sugmanue and
joewyz
and removed request for
sugmanue
joewyz
approved these changes
Apr 7, 2025
|
What happens if you write a top level member? |
@JordonPhillips This only effects syntax highlighting, so it'll be highlighted, but everything else will work as it currently does. You'll get an error diagnostic, and you won't get erroneous completions suggesting a top level member |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a grammar pattern at the top level for members. While members at the top level aren't valid syntax, having a pattern for them means we can have syntax highlighting in rendered hover content for members.
Before:
After:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.