feat: replace uuid.v4 with crypto.randomUUID() #1657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
requested changes
Aug 1, 2025
| boolean isRequired = binding.getMember().isRequired(); | ||
| String idempotencyComponent = (isIdempotencyToken && !isRequired) ? " ?? generateIdempotencyToken()" : ""; | ||
| String idempotencyComponent = (isIdempotencyToken && !isRequired) ? " ?? crypto.randomUUID()" : ""; |
There was a problem hiding this comment.
This is runtime agnostic file, and crypto is not available globally the minimum version of Node.js, i.e. 18.0.0, as per my tests
$ nvm use 18.0.0
Now using node v18.0.0 (npm v8.6.0)
$ cat randomUUID.mjs
console.log(crypto.randomUUID());
$ node randomUUID.mjs
file:///Users/trivikr/workspace/test/randomUUID.mjs:1
console.log(crypto.randomUUID());
^
ReferenceError: crypto is not defined
at file:///Users/trivikr/workspace/test/randomUUID.mjs:1:13
at ModuleJob.run (node:internal/modules/esm/module_job:198:25)
at async Promise.all (index 0)
at async ESMLoader.import (node:internal/modules/esm/loader:409:24)
at async loadESM (node:internal/process/esm_loader:85:5)
at async handleMainPromise (node:internal/modules/run_main:61:12)
Node.js v18.0.0There was a problem hiding this comment.
The crypto was added globally as follows:
- v23.0.0 | No longer experimental.
- v19.0.0 | No longer behind --experimental-global-webcrypto CLI flag.
- v17.6.0, v16.15.0 | Added in: v17.6.0, v16.15.0
There was a problem hiding this comment.
We can replace uuid with a utility in core though, where Node.js one will get it from crypto.
That utility can be removed once we drop support for Node.js 22.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws/aws-sdk-js-v3#7212
replace uuid v4 with crypto.randomUUID()
execution environments without global crypto.randomUUID will need a replacement polyfill.