Fix query binding #502
Open
Fix query binding #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
fix-query-binding
branch
from
050dc5e to
052fa4d
Compare
JordonPhillips
force-pushed
the
fix-query-binding
branch
from
052fa4d to
2b72123
Compare
nateprewitt
reviewed
Jun 4, 2025
| @@ -486,7 +486,7 @@ def write_big_decimal(self, schema: Schema, value: Decimal) -> None: | |||
|
|
|||
| def write_string(self, schema: Schema, value: str) -> None: | |||
| key = self._key or schema.expect_trait(HTTPQueryTrait).key | |||
| self.query_params.append((key, urlquote(value, safe=""))) | |||
There was a problem hiding this comment.
Does this have any implications on our current signing setup? The signers can double encode but I'm wondering if we're setting that appropriately if we're removing this.
There was a problem hiding this comment.
This shouldn't affect signing at all. The code generated bindings also produce an encoded query string.
| @@ -328,7 +328,7 @@ def __init__( | |||
| :py:class:`HTTPHeaderTrait` will be checked instead. Required when | |||
| collecting list entries. | |||
| :param headers: An optional list of header tuples to append to. If not | |||
| set, one will be created. | |||
| set, one will be created. Values appended will not be escaped. | |||
There was a problem hiding this comment.
What is handling any required escaping now?
There was a problem hiding this comment.
They're escaped when they're joined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where query values were being double-encoded, and also serialization of maps of lists in the query string
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.