-
Notifications
You must be signed in to change notification settings - Fork 1
[GS-5825]/provide support for typescript_Engineering Ticket #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Blocker[ All the tsconfig.json
fles are pretty much the same. Consolidate them all to tsconfig.all.jsonc
and have only the differting options and extends
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
Coverage after merging GS-5825/support-for-typescript into main will be
Coverage Report
|
@@ -16,6 +20,7 @@ | |||
"@changesets/cli": "^2.26.0", | |||
"@flex-development/toggle-pkg-type": "^1.0.1", | |||
"@vitest/coverage-v8": "^2.1.1", | |||
"concurrently": "^9.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocker: This package is not being used so it can be removed.
@@ -25,6 +30,8 @@ | |||
"glob": "^8.1.0", | |||
"minimist": "^1.2.7", | |||
"prettier": "^2.8.3", | |||
"tsx": "^4.19.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocker: This package is not being used so it can be removed.
Overview
Jira
GS-5825
Requirement
Contexture has never been user friendly, which is compounded by the fact that there is little documentation and no types. This ticket aims to add TypeScript support to it in order to make it more understandable and usable.
NOTE: This ticket is only about enabling TypeScript, not typing the code!
Verifying
I am testing by renaming a file
packages/client/src/listeners.js
to .ts extension . After that I ran a commandtsc --noEmit
at client folder , and it starts giving Typescript error .