文字列リテラルでエスケープできるようにする #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuchida
commented
Jun 17, 2021
| string = '"' (any - '"')* '"' | "'" (any - "'")* "'" ; # TODO escapes | ||
|
|
||
| dqchar = [^"\\] | ( '\\' any ); | ||
| string = '"' . dqchar* . '"' | "'" (any - "'")* "'" ; |
Collaborator
Author
There was a problem hiding this comment.
| if lex.data[lex.ts] == '\'' { | ||
| s = string(lex.data[lex.ts+1:lex.te-1]) | ||
| } else { | ||
| unquotedStr, err := strconv.Unquote(string(lex.data[lex.ts:lex.te])) |
Collaborator
Author
There was a problem hiding this comment.
https://golang.org/pkg/strconv/#Unquote
strconv.Unquoteはシングルクォートを（文字列ではなく）文字として認識するため、2文字以上あるとエラーになる
ちなみにstrconv.Unquoteは``も有効な文字列として認識するのだけど、字句解析では許容していないので、ここにこないはず
anoChick
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. https://github.com/smartoperation/saasx/issues/3675, osteele#45
まずLiquidはShopifyのものが本家みたいなんだけど、その仕様では文字列リテラルのエスケープをしないと書いてある
https://shopify.github.io/liquid/basics/types/#string
このproposalでは``内ではエスケープできるようにするという仕様が提案されている
Shopify/liquid#1174 (comment)
本PRでは、クライアント側の都合によりJSONと互換性があると楽なのと、
strconv.Unquoteがよさそうだったので、""のみエスケープする、という実装にした