Skip to content

Eliminate all lint warnings #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Eliminate all lint warnings #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
coverage/**/*.js
examples/**/*.bundle.js
3 changes: 3 additions & 0 deletions examples/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
module.exports = {
"env": {
"node": true,
},
"rules": {
"no-console": [0],
}
};
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@
"copy-webpack-plugin": "^4.0.1",
"eslint": "^3.14.0",
"mkdirp": "^0.5.1",
"mocha": "^3.2.0",
"nyc": "^10.1.2",
"mocha": "^5.2.0",
"nyc": "^13.0.1",
"webpack": "^1.14.0"
}
}
3 changes: 3 additions & 0 deletions test/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,7 @@ module.exports = {
"node": true,
"mocha": true
},
"rules": {
"no-console": [0],
}
};
2 changes: 1 addition & 1 deletion test/04-version-stamp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ describe("version-stamp VersionStamp", function () {
var filename;
before("create a temporary build file", function (done) {
filename = path.normalize(".build");
fs.unlink(filename, function (err) {
fs.unlink(filename, function () {
fs.writeFile(filename, "1", function (err) {
done(err);
});
Expand Down
4 changes: 2 additions & 2 deletions test/05-examples.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const failingExamples = [
];

describe("examples", function () {
for (var i = 0, len = examples.length; i < len; ++i) {
for (let i = 0, len = examples.length; i < len; ++i) {
(function (name) {
it("should run the " +name+ " example.", function (done) {
this.timeout(2000);
Expand All @@ -134,7 +134,7 @@ describe("examples", function () {
});
})(examples[i]);
}
for (var i = 0, len = failingExamples.length; i < len; ++i) {
for (let i = 0, len = failingExamples.length; i < len; ++i) {
(function (name) {
it("should fail the " +name+ " example.", function (done) {
this.timeout(2000);
Expand Down