Server side changes for using saved fix coordinates with for the RTK base #10
Conversation
|
Marcell Zahoran seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| self.descriptor = descriptor | ||
|
|
||
| position = getattr(packet, "position", None) | ||
| if position is not None: |
There was a problem hiding this comment.
It would be great to use the newly added set_from_ecef() method here (and everywhere where we are modifying self.position, self.position_ecef and self._antenna_position_timestamp at the same time.
| self.position_ecef = position | ||
| self._antenna_position_timestamp = monotonic() | ||
|
|
||
| def set_from_ecef(self, position: ECEFCoordinate) -> None: |
There was a problem hiding this comment.
Please add documentation for this method.
| preset_id, desired_preset = None, None | ||
|
|
||
| # Always reset fixed position when switching RTK source | ||
| self._survey_settings.position = None |
There was a problem hiding this comment.
Can you please double check that if you have a fixed position preset in the server config file those coordinates will be loaded back properly after many preset changes?
4 participants
No description provided.